Bug 66380

Summary:

[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}

Product:

WebKit

Reporter:

Leandro Pereira <leandro>

Component:

New Bugs

Assignee:

Leandro Pereira <leandro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth, rakuco, rniwa, tonikitoo, webkit.review.bot

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

66685, 66782, 68454

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Updated patch which also changes related files	none
Rebase on top of trunk	none

Leandro Pereira

Reported 2011-08-17 08:24:36 PDT

[EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}

Attachments
Patch (14.75 KB, patch) 2011-08-17 09:54 PDT, Leandro Pereira	no flags	Details Formatted Diff Diff
Updated patch which also changes related files (31.36 KB, patch) 2011-09-20 11:29 PDT, Raphael Kubo da Costa (:rakuco)	no flags	Details Formatted Diff Diff
Rebase on top of trunk (31.32 KB, patch) 2011-10-05 11:53 PDT, Raphael Kubo da Costa (:rakuco)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Leandro Pereira

Comment 1 2011-08-17 09:54:35 PDT

Created attachment 104182 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2011-09-20 10:49:07 PDT

*** Bug 66415 has been marked as a duplicate of this bug. ***

Raphael Kubo da Costa (:rakuco)

Comment 3 2011-09-20 10:50:44 PDT

Updating dependency list.

Raphael Kubo da Costa (:rakuco)

Comment 4 2011-09-20 11:29:08 PDT

Created attachment 108032 [details] Updated patch which also changes related files

Raphael Kubo da Costa (:rakuco)

Comment 5 2011-10-02 21:34:41 PDT

CC'ing reviewers.

Kenneth Rohde Christiansen

Comment 6 2011-10-03 09:16:57 PDT

Comment on attachment 108032 [details] Updated patch which also changes related files View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review > Tools/ChangeLog:11 > + * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added. I think the name Chrome is very confusing due to EFL vs Chromium.

Raphael Kubo da Costa (:rakuco)

Comment 7 2011-10-03 09:30:06 PDT

(In reply to comment #6) > (From update of attachment 108032 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review > > > Tools/ChangeLog:11 > > + * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added. > > I think the name Chrome is very confusing due to EFL vs Chromium. It was named after ChromeClient and friends. Is it worth renaming it? Any suggestions?

Raphael Kubo da Costa (:rakuco)

Comment 8 2011-10-05 11:53:54 PDT

Created attachment 109831 [details] Rebase on top of trunk

Antonio Gomes

Comment 9 2011-10-07 09:04:55 PDT

(In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 108032 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=108032&action=review > > > > > Tools/ChangeLog:11 > > > + * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added. > > > > I think the name Chrome is very confusing due to EFL vs Chromium. > > It was named after ChromeClient and friends. Is it worth renaming it? Any suggestions? I tend to agree, but on the other hand I have not better suggestion.

WebKit Review Bot

Comment 10 2011-10-07 09:21:07 PDT

Comment on attachment 109831 [details] Rebase on top of trunk Clearing flags on attachment: 109831 Committed r96943: <http://trac.webkit.org/changeset/96943>

WebKit Review Bot

Comment 11 2011-10-07 09:21:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.