Bug 66357

Summary:

make-script-test-wrappers should not look outside fast/js

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

67747

Bug Blocks:

Attachments:

Description	Flags
proposed patch	none
proposed patch	none

Description Alexey Proskuryakov 2011-08-16 17:36:28 PDT

Splitting tests into HTML and JS parts is harmful:
- it's more difficult to navigate to test source from results page to see what it's actually doing;
- it's more difficult to navigate to it in Finder;
- an extra file per test makes version control slower;
- some people are led to believe that they should dynamically create a DOM from within JavaScript code, making tests even more difficult to follow;
- other people manually modify wrappers, making it a pain to run the script for others.

For fast/js, splitting the tests is likely worth it, as we want to eventually run them from within a pure JS interpreter without WebCore.

Comment 1 Alexey Proskuryakov 2011-08-16 17:38:15 PDT

Created attachment 104131 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2011-08-16 17:41:01 PDT

Comment on attachment 104131 [details]
proposed patch

That's too much, should also look in fast/js subdirectories.

Comment 3 Alexey Proskuryakov 2011-08-16 17:43:43 PDT

Created attachment 104132 [details]
proposed patch

Comment 4 Maciej Stachowiak 2011-10-25 12:59:49 PDT

Comment on attachment 104132 [details]
proposed patch

r=me

Comment 5 WebKit Review Bot 2011-10-25 14:15:47 PDT

Comment on attachment 104132 [details]
proposed patch

Clearing flags on attachment: 104132

Committed r98395: <http://trac.webkit.org/changeset/98395>

Comment 6 WebKit Review Bot 2011-10-25 14:15:52 PDT

All reviewed patches have been landed.  Closing bug.