Bug 66343

Summary: Wire up relative time to garden-o-matic summary view.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64188, 66403    
Attachments:
Description Flags
Patch
none
Patch abarth: review+, abarth: commit-queue-

Dimitri Glazkov (Google)
Reported 2011-08-16 15:37:02 PDT
Wire up relative time to garden-o-matic summary view.
Attachments
Patch (8.00 KB, patch)
2011-08-16 15:39 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (9.97 KB, patch)
2011-08-16 15:44 PDT, Dimitri Glazkov (Google) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-08-16 15:39:24 PDT
Created attachment 104103 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-08-16 15:44:11 PDT
Created attachment 104105 [details] Patch
Adam Barth
Comment 3 2011-08-16 17:16:48 PDT
Comment on attachment 104105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:73 > + get date() I'd prefer not to use getters and settings, but we can use them if you feel strongly. They secretly turn property accesses into function calls that can do scary things.
Dimitri Glazkov (Google)
Comment 4 2011-08-16 18:23:12 PDT
Comment on attachment 104105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:73 >> + get date() > > I'd prefer not to use getters and settings, but we can use them if you feel strongly. They secretly turn property accesses into function calls that can do scary things. I totally agree with you. I keep wanting to use getters and setters, because they are fancy, but always worry about the foot-gun problem. I'll change to use WebKit style date() and setDate().
Dimitri Glazkov (Google)
Comment 5 2011-08-17 14:13:39 PDT
Committed r93241: <http://trac.webkit.org/changeset/93241>
Note You need to log in before you can comment on or make changes to this bug.