| Summary: | Wire up relative time to garden-o-matic summary view. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 64188, 66403 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dimitri Glazkov (Google)
2011-08-16 15:37:02 PDT
Created attachment 104103 [details]
Patch
Created attachment 104105 [details]
Patch
Comment on attachment 104105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:73 > + get date() I'd prefer not to use getters and settings, but we can use them if you feel strongly. They secretly turn property accesses into function calls that can do scary things. Comment on attachment 104105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:73 >> + get date() > > I'd prefer not to use getters and settings, but we can use them if you feel strongly. They secretly turn property accesses into function calls that can do scary things. I totally agree with you. I keep wanting to use getters and setters, because they are fancy, but always worry about the foot-gun problem. I'll change to use WebKit style date() and setDate(). Committed r93241: <http://trac.webkit.org/changeset/93241> |