Bug 66324

Summary: garden-o-matic frontend needs a friendly relative time description method.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66144    
Attachments:
Description Flags
Patch abarth: review+

Dimitri Glazkov (Google)
Reported 2011-08-16 13:04:38 PDT
garden-o-matic frontend needs a friendly relative time description method.
Attachments
Patch (8.40 KB, patch)
2011-08-16 13:11 PDT, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-08-16 13:11:55 PDT
Created attachment 104080 [details] Patch
Adam Barth
Comment 2 2011-08-16 13:49:46 PDT
Comment on attachment 104080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104080&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:311 > +var MINUTE_IN_MILLISECONDS = 60 * 1000; we've been using kMinuteInMilliseconds for these sorts of constants.
Adam Barth
Comment 3 2011-08-16 13:49:53 PDT
very cool
Dimitri Glazkov (Google)
Comment 4 2011-08-16 15:02:31 PDT
Comment on attachment 104080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104080&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:311 >> +var MINUTE_IN_MILLISECONDS = 60 * 1000; > > we've been using kMinuteInMilliseconds for these sorts of constants. D'oh. Will change.
Dimitri Glazkov (Google)
Comment 5 2011-08-16 15:07:51 PDT
Committed r93163: <http://trac.webkit.org/changeset/93163>
Note You need to log in before you can comment on or make changes to this bug.