Bug 66318

Summary:

Summary view should not add multiple entries for the same test failure.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

Tools / Tests

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

66144

Attachments:

Description	Flags
Patch	abarth: review+

Description Dimitri Glazkov (Google) 2011-08-16 10:59:41 PDT

Summary view should not add multiple entries for the same test failure.

Comment 1 Dimitri Glazkov (Google) 2011-08-16 11:01:37 PDT

Created attachment 104068 [details]
Patch

Comment 2 Adam Barth 2011-08-16 13:47:52 PDT

Comment on attachment 104068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104068&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:132
> +        return !!Array.prototype.filter.call(this._tests.children, function(child) {
> +            return child.equals(failureAnalysis);
> +        }).length;

This feels like something to abstract into base, like the any/all functions in Python.

Comment 3 Dimitri Glazkov (Google) 2011-08-16 14:55:52 PDT

Committed r93161: <http://trac.webkit.org/changeset/93161>