Bug 66303

Summary: [REGRESSION] Media controls should always be enabled when scripting is disabled
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tony, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 70872    
Attachments:
Description Flags
Proposed patch dglazkov: review+

Eric Carlson
Reported 2011-08-16 08:06:08 PDT
The spec says "... if scripting is disabled for the media element, then the user agent should expose a user interface to the user"[1]. WebKit previously forced controls to be visible when scripting was disabled, but that was lost along the way. [1] http://www.w3.org/TR/html5/video.html#attr-media-controls
Attachments
Proposed patch (7.57 KB, patch)
2011-08-16 08:45 PDT, Eric Carlson 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-08-16 08:06:28 PDT
<rdar://problem/9961042>
Eric Carlson
Comment 2 2011-08-16 08:45:32 PDT
Created attachment 104052 [details] Proposed patch
Eric Carlson
Comment 3 2011-08-16 09:15:02 PDT
http://trac.webkit.org/changeset/93108
Tony Chang
Comment 4 2011-08-16 10:08:25 PDT
Did you mean to put the -iframe.html file in the resources subdirectory? run-webkit-tests is treating it as a separate test.
Tony Chang
Comment 5 2011-08-16 10:08:33 PDT
I will try to fix.
Tony Chang
Comment 6 2011-08-16 10:16:50 PDT
http://trac.webkit.org/changeset/93123
Eric Carlson
Comment 7 2011-08-16 10:24:37 PDT
(In reply to comment #6) > http://trac.webkit.org/changeset/93123 Thanks Tony!
Eric Carlson
Comment 8 2011-08-16 11:48:08 PDT
(In reply to comment #6) > http://trac.webkit.org/changeset/93123 You shouldn't have had to create Chromium specific results - the test doesn't need to include the control location in the test results. I will fix this.
Eric Carlson
Comment 9 2011-08-16 13:14:34 PDT
http://trac.webkit.org/changeset/93148 should make the results platform independent.
Tony Chang
Comment 10 2011-08-16 13:36:32 PDT
(In reply to comment #9) > http://trac.webkit.org/changeset/93148 should make the results platform independent. Thanks!
Note You need to log in before you can comment on or make changes to this bug.