Bug 66253

Summary: Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload()
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: MediaAssignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 67316    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch jhoneycutt: review+, webkit.review.bot: commit-queue-

Jeff Miller
Reported 2011-08-15 14:09:32 PDT
Currently, MediaPlayerPrivateAVFoundation::setPreload() defers creating the AVPlayerItem on the Mac, but not the AVPlayer, until we know that the asset is playable. We can't do this on Windows, since creating the AVPlayer requires and AVPlayerItem. In reality, we don't need either of these before the asset is playable, so on both platforms we should defer creating the AVPlayer and AVPlayerItem.
Attachments
Patch (2.51 KB, patch)
2011-08-30 15:51 PDT, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2011-08-31 17:11 PDT, Jeff Miller 		jhoneycutt: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-08-15 14:09:51 PDT
<rdar://problem/9956744>
Jeff Miller
Comment 2 2011-08-30 15:51:09 PDT
Created attachment 105712 [details] Patch
Jeff Miller
Comment 3 2011-08-31 14:12:43 PDT
It turns out that this patch doesn't work on the Mac, which I didn't realize because AVFoundation was disabled by bug 67316. I will submit a new patch after I fix 67316.
Jeff Miller
Comment 4 2011-08-31 17:11:55 PDT
Created attachment 105866 [details] Patch
WebKit Review Bot
Comment 5 2011-08-31 18:38:51 PDT
Comment on attachment 105866 [details] Patch Attachment 105866 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9566961 New failing tests: http/tests/loading/empty-urls.html
Jeff Miller
Comment 6 2011-09-01 09:56:15 PDT
(In reply to comment #5) > (From update of attachment 105866 [details]) > Attachment 105866 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9566961 > > New failing tests: > http/tests/loading/empty-urls.html I don't think the test failure is caused by this patch, since the patch only modifies code used in Apple builds.
Jeff Miller
Comment 7 2011-09-01 10:14:42 PDT
Committed r94302: <http://trac.webkit.org/changeset/94302>
Note You need to log in before you can comment on or make changes to this bug.