Bug 66222

Summary:

[Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit2

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2011-08-15 06:12:14 PDT

As Kenneth pointed out, this method is evil because it breaks encapsulation and we have no control over who can access the private object.

Comment 1 Benjamin Poulain 2011-08-15 06:19:50 PDT

Created attachment 103910 [details]
Patch

Comment 2 WebKit Review Bot 2011-08-15 12:07:14 PDT

Comment on attachment 103910 [details]
Patch

Clearing flags on attachment: 103910

Committed r93049: <http://trac.webkit.org/changeset/93049>

Comment 3 WebKit Review Bot 2011-08-15 12:07:18 PDT

All reviewed patches have been landed.  Closing bug.