Bug 66206

Summary: [chromium] Implement shouldRubberBandInDirection
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Nico Weber
Reported 2011-08-14 09:45:40 PDT
[chromium] Implement shouldRubberBandInDirection
Attachments
Patch (3.02 KB, patch)
2011-08-14 09:48 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (3.02 KB, patch)
2011-08-14 13:28 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (3.02 KB, patch)
2011-08-15 10:39 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.02 KB, patch)
2011-08-15 10:47 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-08-14 09:48:54 PDT
Created attachment 103881 [details] Patch
Nico Weber
Comment 2 2011-08-14 13:28:32 PDT
Created attachment 103882 [details] Patch
Nico Weber
Comment 3 2011-08-15 10:09:47 PDT
This goes with http://codereview.chromium.org/7618036/
Adam Barth
Comment 4 2011-08-15 10:32:29 PDT
Comment on attachment 103882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103882&action=review > Source/WebKit/chromium/src/ChromeClientImpl.cpp:977 > + return false; bad indent
Adam Barth
Comment 5 2011-08-15 10:33:00 PDT
Comment on attachment 103882 [details] Patch Can we test this sort of change?
Nico Weber
Comment 6 2011-08-15 10:39:34 PDT
Created attachment 103924 [details] Patch
Nico Weber
Comment 7 2011-08-15 10:40:57 PDT
Comment on attachment 103924 [details] Patch Thanks, I'll look into writing a test for this in.
Nico Weber
Comment 8 2011-08-15 10:43:35 PDT
Looks like writing tests for this is blocked on issue 11042 and on eventSender growing support for gesture events.
Nico Weber
Comment 9 2011-08-15 10:47:08 PDT
Created attachment 103926 [details] Patch for landing
WebKit Review Bot
Comment 10 2011-08-15 12:59:23 PDT
Comment on attachment 103926 [details] Patch for landing Clearing flags on attachment: 103926 Committed r93056: <http://trac.webkit.org/changeset/93056>
WebKit Review Bot
Comment 11 2011-08-15 12:59:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.