Summary: | Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||||
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eae, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 63567 | ||||||||
Attachments: |
|
Description
Levi Weintraub
2011-08-12 11:41:29 PDT
Created attachment 103797 [details]
Patch
Comment on attachment 103797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103797&action=review > Source/WebCore/rendering/RenderListBox.cpp:484 > + IntPoint currentMousePosition = roundedIntPoint(frame()->eventHandler()->currentMousePosition()); Sad times. That we're rounding. :( > Source/WebCore/rendering/RenderListBox.cpp:526 > + LayoutUnit offsetX = destination.x() - absPos.x(); > + LayoutUnit offsetY = destination.y() - absPos.y(); Sounds like a size to me. :( Created attachment 103810 [details]
Patch for landing
Comment on attachment 103810 [details] Patch for landing Clearing flags on attachment: 103810 Committed r92998: <http://trac.webkit.org/changeset/92998> All reviewed patches have been landed. Closing bug. |