Bug 66149 - Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
Summary: Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency treegraph
 
Reported: 2011-08-12 11:41 PDT by Levi Weintraub
Modified: 2011-08-12 14:35 PDT (History)
3 users (show)

See Also:


Attachments
Patch (23.92 KB, patch)
2011-08-12 12:42 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch for landing (27.08 KB, patch)
2011-08-12 13:49 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-08-12 11:41:29 PDT
Ongoing conversion effort...
Comment 1 Levi Weintraub 2011-08-12 12:42:48 PDT
Created attachment 103797 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-08-12 13:17:09 PDT
Comment on attachment 103797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103797&action=review

> Source/WebCore/rendering/RenderListBox.cpp:484
> +    IntPoint currentMousePosition = roundedIntPoint(frame()->eventHandler()->currentMousePosition());

Sad times.  That we're rounding. :(

> Source/WebCore/rendering/RenderListBox.cpp:526
> +    LayoutUnit offsetX = destination.x() - absPos.x();
> +    LayoutUnit offsetY = destination.y() - absPos.y();

Sounds like a size to me. :(
Comment 3 Levi Weintraub 2011-08-12 13:49:34 PDT
Created attachment 103810 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-08-12 14:35:17 PDT
Comment on attachment 103810 [details]
Patch for landing

Clearing flags on attachment: 103810

Committed r92998: <http://trac.webkit.org/changeset/92998>
Comment 5 WebKit Review Bot 2011-08-12 14:35:21 PDT
All reviewed patches have been landed.  Closing bug.