Summary: | Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Færøy <ahf> | ||||||
Component: | WebKit2 | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, kenneth, ossy, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexander Færøy
2011-08-12 05:03:20 PDT
Created attachment 103763 [details]
Patch
Comment on attachment 103763 [details] Patch Attachment 103763 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9358617 Comment on attachment 103763 [details] Patch Attachment 103763 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9357626 Comment on attachment 103763 [details]
Patch
Please fix the build error anyway.
Comment on attachment 103763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103763&action=review > Source/WebCore/page/Frame.cpp:911 > - frameView->setUseFixedLayout(useFixedLayout); > + frameView->setUseFixedLayout(!fixedLayoutSize.isEmpty()); So how do you turn it on the first time? I mean the view is created before we get the layout size (viewport meta tag) > Source/WebKit2/ChangeLog:1 > +2011-08-12 Alexander Færøy <alexander.faeroy@nokia.com> Something is up with your name! > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:668 > + // FIXME: ??? frame->view()->forceLayout(); What do you mean with that? You set needslayout below Created attachment 111000 [details]
Patch
Comment on attachment 111000 [details]
Patch
r=me
Comment on attachment 111000 [details] Patch Clearing flags on attachment: 111000 Committed r97462: <http://trac.webkit.org/changeset/97462> All reviewed patches have been landed. Closing bug. You guys broke the SL build: /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: In member function 'virtual void WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage()': /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1116: warning: unused variable 'view' Reopen to fix it. Fix landed: http://trac.webkit.org/changeset/97465 |