Bug 66126

Summary: Implement animation and transition properties in CSSStyleApplyProperty.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, macpherson, mitz, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66118    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Luke Macpherson
Reported 2011-08-11 22:25:33 PDT
Implement animation and transition properties in CSSStyleApplyProperty.
Attachments
Patch (20.69 KB, patch)
2011-08-11 22:30 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (21.17 KB, patch)
2011-08-14 17:37 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (21.17 KB, patch)
2011-08-14 18:10 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-08-11 22:30:26 PDT
Created attachment 103737 [details] Patch
WebKit Review Bot
Comment 2 2011-08-12 00:53:57 PDT
Comment on attachment 103737 [details] Patch Attachment 103737 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9352481
WebKit Review Bot
Comment 3 2011-08-12 01:15:08 PDT
Comment on attachment 103737 [details] Patch Attachment 103737 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9358546
Luke Macpherson
Comment 4 2011-08-14 17:37:31 PDT
Created attachment 103886 [details] Patch
WebKit Review Bot
Comment 5 2011-08-14 17:40:11 PDT
Attachment 103886 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/animation/Animation.cpp:133: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Luke Macpherson
Comment 6 2011-08-14 18:10:44 PDT
Created attachment 103887 [details] Patch
Luke Macpherson
Comment 7 2011-08-21 22:41:56 PDT
One-week ping! Could someone please review this?
Dean Jackson
Comment 8 2011-08-24 18:59:12 PDT
I'd like to review this. See my comments in 66118. I should get to the review later today or tomorrow.
Luke Macpherson
Comment 9 2011-08-24 19:01:02 PDT
Thanks Dean. I had actually forgotten about the other bug :)
WebKit Review Bot
Comment 10 2011-08-25 18:32:33 PDT
Comment on attachment 103887 [details] Patch Clearing flags on attachment: 103887 Committed r93848: <http://trac.webkit.org/changeset/93848>
WebKit Review Bot
Comment 11 2011-08-25 18:32:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.