Summary: | REGRESSION: Qt JavaScript bridge signal connection fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wason <rectalogic> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | erights, jwalden+bwo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andrew Wason
2011-08-11 14:16:39 PDT
A workaround is to pass an anonymous object as the first arg to connect, e.g.: context.someSignal.connect({}, function() { }); Because otherwise JSC::Bindings::QtRuntimeConnectionMethod::call() uses the window object (exec->lexicalGlobalObject()) and that seems to trigger the assert. See http://trac.webkit.org/browser/trunk/Source/WebCore/bridge/qt/qt_runtime.cpp#L1587 Created attachment 103719 [details] pass toThisObject() to JS signal handler This also re-enables tst_QWebFrame::connectAndDisconnect() tests that were disabled with bug 65170 Comment on attachment 103719 [details]
pass toThisObject() to JS signal handler
Ooops, apologies for the breakage! - thanks for the fix.
Comment on attachment 103719 [details] pass toThisObject() to JS signal handler Clearing flags on attachment: 103719 Committed r92907: <http://trac.webkit.org/changeset/92907> All reviewed patches have been landed. Closing bug. |