Bug 66091

Summary: Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan, isSpanWithoutAttributesOrUnstyleStyleSpan and replaceWithSpanOrRemoveIfWithoutAttributes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, darin, enrica, eric, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 12248    
Attachments:
Description Flags
refactoring none

Ryosuke Niwa
Reported 2011-08-11 13:29:18 PDT
The following functions all check similar conditions: isStyleSpanOrSpanWithOnlyStyleAttribute isUnstyledStyleSpan isSpanWithoutAttributesOrUnstyleStyleSpan ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes We should merge them together.
Attachments
refactoring (7.61 KB, patch)
2011-08-11 14:30 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-08-11 14:30:36 PDT
Created attachment 103672 [details] refactoring
Ryosuke Niwa
Comment 2 2011-08-11 16:11:59 PDT
Thanks for the review!
WebKit Review Bot
Comment 3 2011-08-11 16:43:25 PDT
Comment on attachment 103672 [details] refactoring Clearing flags on attachment: 103672 Committed r92891: <http://trac.webkit.org/changeset/92891>
WebKit Review Bot
Comment 4 2011-08-11 16:43:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.