Summary: | Expose pageScaleFactor() to Chromium's WebViewImpl | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fady Samuel <fsamuel> | ||||||
Component: | New Bugs | Assignee: | Fady Samuel <fsamuel> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fishd, fsamuel, rjkroege, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fady Samuel
2011-08-11 09:35:20 PDT
Created attachment 103637 [details]
Patch
Comment on attachment 103637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103637&action=review > Source/WebKit/chromium/public/WebView.h:206 > + virtual double pageScaleFactor() const = 0; it seems odd that this returns double when scalePage takes a float. one of these should change to match the other. zoom uses double. maybe page scaling should use double too? Created attachment 103653 [details]
Patch
(In reply to comment #3) > Created an attachment (id=103653) [details] > Patch Fixed as suggested by fishd Comment on attachment 103653 [details] Patch Clearing flags on attachment: 103653 Committed r93007: <http://trac.webkit.org/changeset/93007> All reviewed patches have been landed. Closing bug. |