Bug 66067

Summary: Expose pageScaleFactor() to Chromium's WebViewImpl
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, fsamuel, rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Fady Samuel
Reported 2011-08-11 09:35:20 PDT
Expose pageScaleFactor() to Chromium's WebViewImpl
Attachments
Patch (2.89 KB, patch)
2011-08-11 09:35 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (3.01 KB, patch)
2011-08-11 12:15 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-08-11 09:35:56 PDT
Created attachment 103637 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2011-08-11 11:51:31 PDT
Comment on attachment 103637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103637&action=review > Source/WebKit/chromium/public/WebView.h:206 > + virtual double pageScaleFactor() const = 0; it seems odd that this returns double when scalePage takes a float. one of these should change to match the other. zoom uses double. maybe page scaling should use double too?
Fady Samuel
Comment 3 2011-08-11 12:15:44 PDT
Created attachment 103653 [details] Patch
Fady Samuel
Comment 4 2011-08-12 09:31:52 PDT
(In reply to comment #3) > Created an attachment (id=103653) [details] > Patch Fixed as suggested by fishd
WebKit Review Bot
Comment 5 2011-08-12 15:56:49 PDT
Comment on attachment 103653 [details] Patch Clearing flags on attachment: 103653 Committed r93007: <http://trac.webkit.org/changeset/93007>
WebKit Review Bot
Comment 6 2011-08-12 15:56:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.