Bug 66050

Summary:

Web Inspector: Resources panel: display the current search match index in the toolbar.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

61119

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+

Description Vsevolod Vlasov 2011-08-11 06:17:21 PDT

Resources panel: display the current search match index in the toolbar.

Comment 1 Vsevolod Vlasov 2011-08-11 06:26:04 PDT

Created attachment 103613 [details]
Patch

Comment 2 Pavel Feldman 2011-08-11 07:55:11 PDT

Comment on attachment 103613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103613&action=review

Too much logic here, please provide a test.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1632
> +            return this._searchResult(this._traverser.next(currentTreeElement), 0, this._currentMatchIndex % this._matchesCount + 1);

Why % ? Shouldn't _currentMatchIndex be normalized on its own?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1650
> +                return this._searchResult(treeElement, treeElement.searchMatchesCount - 1, currentMatchIndex);

I think this requires a test!

Comment 3 Vsevolod Vlasov 2011-10-25 03:23:51 PDT

Created attachment 112314 [details]
Patch

Comment 4 Vsevolod Vlasov 2011-10-25 06:48:41 PDT

Committed r98339: <http://trac.webkit.org/changeset/98339>