Bug 66035

Summary:

Web Inspector: expand exception properties when wrapping it as object.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Screenshot.	none
Proposed fix(preliminary version)	none
Patch	none
Patch	pfeldman: review+

Pavel Feldman

Reported 2011-08-10 23:45:19 PDT

Otherwise, exception is not informative: renders getters instead of values.

Attachments
[IMAGE] Screenshot. (18.57 KB, image/png) 2011-08-10 23:45 PDT, Pavel Feldman	no flags	Details
Proposed fix(preliminary version) (5.75 KB, patch) 2011-08-11 07:58 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (2.63 KB, patch) 2011-08-12 06:48 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (9.72 KB, patch) 2011-08-12 07:46 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-08-10 23:45:44 PDT

Created attachment 103584 [details] [IMAGE] Screenshot.

Yury Semikhatsky

Comment 2 2011-08-11 07:58:27 PDT

Created attachment 103624 [details] Proposed fix(preliminary version)

Yury Semikhatsky

Comment 3 2011-08-12 06:48:13 PDT

Created attachment 103768 [details] Patch

Pavel Feldman

Comment 4 2011-08-12 06:52:47 PDT

Comment on attachment 103768 [details] Patch Please provide a test.

WebKit Review Bot

Comment 5 2011-08-12 07:15:58 PDT

Comment on attachment 103768 [details] Patch Attachment 103768 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9353623 New failing tests: inspector/console/console-eval-global.html inspector/console/console-eval-syntax-error.html inspector/console/console-eval-undefined-override.html inspector/runtime/runtime-setPropertyValue.html

Yury Semikhatsky

Comment 6 2011-08-12 07:46:23 PDT

Created attachment 103771 [details] Patch

Yury Semikhatsky

Comment 7 2011-08-12 07:47:22 PDT

(In reply to comment #4) > (From update of attachment 103768 [details]) > Please provide a test. Done. The tests are already there, just needed to run them and rebaseline results.

Yury Semikhatsky

Comment 8 2011-08-12 07:52:18 PDT

Committed r92961: <http://trac.webkit.org/changeset/92961>

Note You need to log in before you can comment on or make changes to this bug.