Summary: | [EFL] Change condition checking logic related with both change of position and offset for backing store. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | KwangHyuk <hyuki.kim> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | antognolli+webkit, aroben, gyuyoung.kim, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
KwangHyuk
2011-08-10 19:16:32 PDT
Created attachment 103569 [details]
Patch,
Attachment 103569 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 103571 [details]
Patch,
Comment on attachment 103571 [details]
Patch,
Informal r+.
LGTM also. Comment on attachment 103571 [details] Patch, View in context: https://bugs.webkit.org/attachment.cgi?id=103571&action=review > Source/WebKit/efl/ChangeLog:7 > + As backing store's position and offset change can be occurred at the same time, > + the checking of offset change shouldn't be a "else if" statement. "can be occurred" should just be "can occur". 'a "else if"' should be 'an "else if"'. Created attachment 104494 [details]
Patch.
>"can be occurred" should just be "can occur".
>'a "else if"' should be 'an "else if"'.
Patched. :-)
Thank you for your review again.
Comment on attachment 104494 [details] Patch. Clearing flags on attachment: 104494 Committed r93409: <http://trac.webkit.org/changeset/93409> All reviewed patches have been landed. Closing bug. |