Bug 66023

Summary:

Web Inspector: Console logging of arrays is not useful

Product:

WebKit

Reporter:

johnjbarton <johnjbarton>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

ASSIGNED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, inspector-bugzilla-changes, jonowells, keishi, loislo, me, paulirish, pfeldman, pmuellr, rik, webkit-bug-importer, webkit.review.bot, yurys

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

116924

Attachments:

Description	Flags
test case, look in Console	none
[IMAGE] Looks with patch applied.	none
[PATCH] Patch with no JSC baselines yet.	none
[PATCH] Proposed change	none
Patch	none
[PATCH] Rebaselined.	none

johnjbarton

Reported 2011-08-10 17:07:22 PDT

Open the attached html file and look at the console output. It's really impossible to tell what the array is really like. Firebug's output is too long but at least it gives you a sense of the array.

Attachments
test case, look in Console (4.57 KB, text/html) 2011-08-10 17:07 PDT, johnjbarton	no flags	Details
[IMAGE] Looks with patch applied. (19.78 KB, image/png) 2011-08-17 10:48 PDT, Pavel Feldman	no flags	Details
[PATCH] Patch with no JSC baselines yet. (20.45 KB, patch) 2011-08-17 11:46 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[PATCH] Proposed change (27.36 KB, patch) 2011-08-18 12:05 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (29.50 KB, patch) 2011-08-19 02:52 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[PATCH] Rebaselined. (28.51 KB, patch) 2011-08-25 05:44 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

johnjbarton

Comment 1 2011-08-10 17:07:54 PDT

Created attachment 103560 [details] test case, look in Console

Pavel Feldman

Comment 2 2011-08-10 23:02:39 PDT

We should enrich our formatting of both arrays and objects while inspector is visible to the one similar to FB. Unfortunately, opening inspector post-factum will still render things as they are (otherwise we need to spend too much time resolving/formatting objects). Btw, var aFlatArray = []; for (var i = 0; i < 1000000; ++i) { aFlatArray[i] = i } ...will kill both Firebug and DevTools. I'm fixing it in https://bugs.webkit.org/show_bug.cgi?id=64596.

Pavel Feldman

Comment 3 2011-08-17 10:48:11 PDT

Created attachment 104192 [details] [IMAGE] Looks with patch applied.

Pavel Feldman

Comment 4 2011-08-17 11:46:15 PDT

Created attachment 104206 [details] [PATCH] Patch with no JSC baselines yet.

Pavel Feldman

Comment 5 2011-08-18 12:05:51 PDT

Created attachment 104379 [details] [PATCH] Proposed change

WebKit Review Bot

Comment 6 2011-08-18 12:37:51 PDT

Comment on attachment 104379 [details] [PATCH] Proposed change Attachment 104379 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9424754 New failing tests: inspector/console/console-log-toString-object.html

Pavel Feldman

Comment 7 2011-08-19 02:52:34 PDT

Created attachment 104482 [details] Patch

Yury Semikhatsky

Comment 8 2011-08-24 02:16:23 PDT

Comment on attachment 104482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104482&action=review > LayoutTests/platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:4 > +{a:1, self:, __proto__:} There should be a value even if it's recursive. > Source/WebCore/inspector/front-end/ConsoleView.js:796 > if (name == parseInt(name)) Remove this and next lines and break when the length property is found.

Pavel Feldman

Comment 9 2011-08-25 05:44:24 PDT

Created attachment 105164 [details] [PATCH] Rebaselined.

Pavel Feldman

Comment 10 2011-08-29 12:34:00 PDT

Comment on attachment 105164 [details] [PATCH] Rebaselined. Clearing r? for now.

Paul Irish

Comment 11 2012-08-02 07:44:11 PDT

*** Bug 61427 has been marked as a duplicate of this bug. ***

Radar WebKit Bug Importer

Comment 12 2014-12-17 11:20:49 PST

<rdar://problem/19281460>

Note You need to log in before you can comment on or make changes to this bug.