Bug 66006

Summary: The PageSerializer should always use absolute URL
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jcivelli, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-08-10 13:07:01 PDT
In http://trac.webkit.org/changeset/92769/trunk/Source/WebCore/page/PageSerializer.cpp I added a Fixme for the URL resolution method. I am pretty sure the existing resolving behavior is wrong or the code of the PageSerializer is wrong. The url resources fetched are all stored with resolved URLs.
Attachments
Patch (1.70 KB, patch)
2011-08-11 10:00 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-08-11 10:00:42 PDT
Created attachment 103640 [details] Patch
Benjamin Poulain
Comment 2 2011-08-11 10:04:42 PDT
This is a purely speculative patch that is completely untested :) I left apart the privacy issues of exposing the local directory as this is not addressed by the current PageSerializer.
Benjamin Poulain
Comment 3 2011-08-11 13:13:18 PDT
Jay, any opinion? I don't mind you guys reject the patch and the Chromium team take over to fix that with a test. I just wanted to point out a problem that become visible due to r92769.
Adam Barth
Comment 4 2011-08-11 13:15:53 PDT
Thanks Ben. Let's see what Jay thinks we should do here.
Jay Civelli
Comment 5 2011-08-11 14:01:24 PDT
Yes, this patch is right. We want to resolve all URLs including local ones.
Adam Barth
Comment 6 2011-08-11 14:02:56 PDT
Comment on attachment 103640 [details] Patch Ok.
WebKit Review Bot
Comment 7 2011-08-11 15:02:46 PDT
Comment on attachment 103640 [details] Patch Clearing flags on attachment: 103640 Committed r92883: <http://trac.webkit.org/changeset/92883>
WebKit Review Bot
Comment 8 2011-08-11 15:02:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.