Summary: | Remove ifdefs for CSS exclusions and CSS regions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mihnea, peter, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 57312 | ||||||||
Attachments: |
|
Description
Dave Hyatt
2011-08-10 12:39:57 PDT
Created attachment 103519 [details]
Patch
Comment on attachment 103519 [details]
Patch
There are other FeatureDefines.xcconfig files that need to be modified (in places like Source/WebKit2/Configurations, e.g.). And you need to modify WebKitLibraries/win/tools/vsprops/FeatureDefines.*. And maybe other places for other ports, too. And you'll need to modify build-webkit to remove the Regions-related flags, and the files in Tools/BuildSlaveSupport/build.webkit.org-config that control how the CSSRegions bot operates.
Created attachment 103525 [details]
Patch v2
Comment on attachment 103525 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=103525&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:259 > - } > + } } Whoops. You also need to delete the declaration of adobe-mac-slave1 higher up in the file. This patch deleted the PlatformSpecificSchedule for all SnowLeopard bots :(. Fixed in http://trac.webkit.org/changeset/92820. |