Bug 65998

Summary: [Qt] Enable WebGL by default for QtWebKit (except on Windows)
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, laszlo.gombos, ossy, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Noam Rosenthal
Reported 2011-08-10 10:50:12 PDT
It's time to make building WebGL on Qt an opt-out instead of an opt-in. We'd still keep it opt-in in the settings.
Attachments
Patch (1.69 KB, patch)
2011-08-10 15:33 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2011-08-10 15:33:18 PDT
Created attachment 103542 [details] Patch
Benjamin Poulain
Comment 2 2011-08-10 17:08:26 PDT
Comment on attachment 103542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103542&action=review > Source/WebCore/features.pri:125 > +contains(QT_CONFIG, opengl) { Before you land, could you check if that still work on Qt5? ...since gl is always available there?
Noam Rosenthal
Comment 3 2011-08-10 17:11:05 PDT
(In reply to comment #2) > (From update of attachment 103542 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103542&action=review > > > Source/WebCore/features.pri:125 > > +contains(QT_CONFIG, opengl) { > > Before you land, could you check if that still work on Qt5? ...since gl is always available there? You mean does the flag work? Checked. Works.
WebKit Review Bot
Comment 4 2011-08-10 17:28:01 PDT
Comment on attachment 103542 [details] Patch Clearing flags on attachment: 103542 Committed r92805: <http://trac.webkit.org/changeset/92805>
WebKit Review Bot
Comment 5 2011-08-10 17:28:05 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2011-08-11 01:52:39 PDT
It broke all fast/canvas/webgl tests ... I skipped them: https://trac.webkit.org/changeset/92805 Reopen to fix them or file a bug report.
Csaba Osztrogonác
Comment 7 2011-08-11 01:54:24 PDT
And it broke Windows build too ... Reni had to disable WebGL on Windows: https://trac.webkit.org/changeset/92830
Benjamin Poulain
Comment 8 2011-08-11 02:21:07 PDT
(In reply to comment #7) > And it broke Windows build too ... > Reni had to disable WebGL on Windows: https://trac.webkit.org/changeset/92830 Interesting. I guess we will have to investigate ANGLE sooner than expected.
Csaba Osztrogonác
Comment 9 2011-09-25 15:14:51 PDT
Why did you close it? WebGL is still disabled on Windows ...
Noam Rosenthal
Comment 10 2011-09-25 23:30:14 PDT
(In reply to comment #9) > Why did you close it? WebGL is still disabled on Windows ... It's confusing. We should create a new bug specificly for windows.
Csaba Osztrogonác
Comment 11 2011-09-25 23:37:50 PDT
Reni filed a new bug report about it, but missed to mention it here: https://bugs.webkit.org/show_bug.cgi?id=66042
Noam Rosenthal
Comment 12 2011-09-26 00:18:37 PDT
Thanks for changing the bug desc. - I should have done that when closing the bug.
Note You need to log in before you can comment on or make changes to this bug.