Bug 65964

Summary:

[Chromium] plugins/keyboard-events.html should pass on linux/mac

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

Tools / Tests

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, tkent, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch sync up.	none

noel gordon

Reported 2011-08-10 00:13:56 PDT

Final sea of red. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fkeyboard-events.html

Attachments
Patch (3.84 KB, patch) 2011-08-10 01:13 PDT, noel gordon	no flags	Details Formatted Diff Diff
Patch sync up. (3.86 KB, patch) 2011-08-22 02:25 PDT, noel gordon	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2011-08-10 01:13:36 PDT

Created attachment 103450 [details] Patch

noel gordon

Comment 2 2011-08-10 01:25:15 PDT

I note the linux result outputs an empty keycode -- that is a progression. There is a FIXME note in the test plugin code about that: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp?rev=88712#L644 The FIXME code is there, keyEventToChar(), but it produces an empty char with the chromium linux DRT. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp?rev=88712#L623 This because the chromium linux DRT creates a keyboard event but fails to fill in the native GTK keycode in that field of the event.

Tony Chang

Comment 3 2011-08-10 09:55:59 PDT

Do we know why we get an empty keycode with Chromium's DRT? It seems to be working for GTK+.

noel gordon

Comment 4 2011-08-22 02:23:10 PDT

(In reply to comment #3) > Do we know why we get an empty keycode with Chromium's DRT? It seems to be working for GTK+. The GTK port creates an honest to goodness GdkEvent keypress event http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/EventSender.cpp?rev=85516#L612 Chromium's DRT generates a WebKeyboardEvent, defined by the webkit api http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/EventSender.cpp?rev=85516#L566 and fills in the WebKeyboardEvent.windowsKeyCode field, but not the nativeKeyCode field http://trac.webkit.org/browser/trunk/WebKit/chromium/public/WebInputEvent.h?rev=50721#L153 The plugin is sent the nativeKeyCode value. That works in the real browser case, but not with the Chromium DRT. Is there a table somewhere that maps webkit::VKEY_CODE to native key codes?

noel gordon

Comment 5 2011-08-22 02:25:35 PDT

Created attachment 104655 [details] Patch sync up.

Tony Chang

Comment 6 2011-08-22 10:10:11 PDT

Comment on attachment 104655 [details] Patch sync up. Seems fine. I filed bug 66679 about fixing the missing key codes. Seems OK to just add a table for use by chromium's drt.

WebKit Review Bot

Comment 7 2011-08-22 11:06:13 PDT

Comment on attachment 104655 [details] Patch sync up. Clearing flags on attachment: 104655 Committed r93519: <http://trac.webkit.org/changeset/93519>

WebKit Review Bot

Comment 8 2011-08-22 11:06:18 PDT

All reviewed patches have been landed. Closing bug.

noel gordon

Comment 9 2011-08-22 20:59:21 PDT

The Skia for the Mac transition is now active. Move the chromium mac keyboard-events.html result to platform/chromium-cg-mac while this transition happens. http://trac.webkit.org/changeset/93554.

Note You need to log in before you can comment on or make changes to this bug.