Bug 65962

Summary:

Web Inspector: live edit both for JS and CSS is not discoverable.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Suggested solution	none
[PATCH] Style fixed	none
[PATCH] Comments addressed	none
[PATCH] Binary diff (with the changed glyph image)	yurys: review+

Pavel Feldman

Reported 2011-08-09 22:53:48 PDT

FB's Live Edit button makes it more explicit.

Attachments
[PATCH] Suggested solution (12.24 KB, patch) 2011-09-08 07:13 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[PATCH] Style fixed (12.25 KB, patch) 2011-09-08 07:14 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[PATCH] Comments addressed (11.32 KB, patch) 2011-09-08 07:56 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[PATCH] Binary diff (with the changed glyph image) (20.50 KB, patch) 2011-09-08 07:57 PDT, Alexander Pavlov (apavlov)	yurys: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2011-09-08 07:13:46 PDT

Created attachment 106730 [details] [PATCH] Suggested solution This is the first take on the feature. The button placement seems a bit odd in the Resources panel, and suggestions on a better "Live Edit" glyph are most welcome.

Alexander Pavlov (apavlov)

Comment 2 2011-09-08 07:14:59 PDT

Created attachment 106731 [details] [PATCH] Style fixed

Yury Semikhatsky

Comment 3 2011-09-08 07:38:44 PDT

Comment on attachment 106730 [details] [PATCH] Suggested solution View in context: https://bugs.webkit.org/attachment.cgi?id=106730&action=review > Source/WebCore/ChangeLog:6 > + Add the "Edit" button to SourceFrame, so that resources/scripts can be edited both in the Wrong alignment. > Source/WebCore/inspector/front-end/ScriptsPanel.js:1148 > + _toggleEditSource: function() This is never called, r- for this.

Yury Semikhatsky

Comment 4 2011-09-08 07:44:07 PDT

Comment on attachment 106731 [details] [PATCH] Style fixed View in context: https://bugs.webkit.org/attachment.cgi?id=106731&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:47 > + this._editButton.addEventListener("click", this._editButtonClicked.bind(this, true), this); _editButtonClicked expects no parameters, no need to bind it to "true". > Source/WebCore/inspector/front-end/SourceFrame.js:838 > + if (!this.startEditing()) You can omit the if, just call the method.

Yury Semikhatsky

Comment 5 2011-09-08 07:48:52 PDT

Alexander Pavlov (apavlov)

Comment 6 2011-09-08 07:56:10 PDT

Created attachment 106737 [details] [PATCH] Comments addressed

Alexander Pavlov (apavlov)

Comment 7 2011-09-08 07:57:45 PDT

Created attachment 106738 [details] [PATCH] Binary diff (with the changed glyph image)

Alexander Pavlov (apavlov)

Comment 8 2011-09-09 03:15:36 PDT

Committed r94842: <http://trac.webkit.org/changeset/94842>

Note You need to log in before you can comment on or make changes to this bug.