| Summary: | Web Inspector: live edit both for JS and CSS is not discoverable. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Pavel Feldman
2011-08-09 22:53:48 PDT
Created attachment 106730 [details]
[PATCH] Suggested solution
This is the first take on the feature. The button placement seems a bit odd in the Resources panel, and suggestions on a better "Live Edit" glyph are most welcome.
Created attachment 106731 [details]
[PATCH] Style fixed
Comment on attachment 106730 [details] [PATCH] Suggested solution View in context: https://bugs.webkit.org/attachment.cgi?id=106730&action=review > Source/WebCore/ChangeLog:6 > + Add the "Edit" button to SourceFrame, so that resources/scripts can be edited both in the Wrong alignment. > Source/WebCore/inspector/front-end/ScriptsPanel.js:1148 > + _toggleEditSource: function() This is never called, r- for this. Comment on attachment 106731 [details] [PATCH] Style fixed View in context: https://bugs.webkit.org/attachment.cgi?id=106731&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:47 > + this._editButton.addEventListener("click", this._editButtonClicked.bind(this, true), this); _editButtonClicked expects no parameters, no need to bind it to "true". > Source/WebCore/inspector/front-end/SourceFrame.js:838 > + if (!this.startEditing()) You can omit the if, just call the method. Comment on attachment 106731 [details] [PATCH] Style fixed View in context: https://bugs.webkit.org/attachment.cgi?id=106731&action=review > Source/WebCore/inspector/front-end/TextViewer.js:922 > + this._container.focus(); Move this call after the check below? Created attachment 106737 [details]
[PATCH] Comments addressed
Created attachment 106738 [details]
[PATCH] Binary diff (with the changed glyph image)
Committed r94842: <http://trac.webkit.org/changeset/94842> |