| Summary: | [Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||
| Component: | WebKit Qt | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gmak, tonikitoo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kenneth Rohde Christiansen
2011-08-09 04:02:49 PDT
Created attachment 103344 [details]
Patch
Comment on attachment 103344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103344&action=review r=me Two comments though. First, I think if we keep this as public API, we should rework it to have proper request/response mapping (though the point/rect mapping that this patch introduces is certainly better than what we had before.) I don't believe this mechanism should be public though, as it could be completely handled by the respective views. Second, after this patch, a FindZoomableAreaForPoint request can now yield no response whatsoever. Given how the "end-user signal" is used, I don't see a problem with it, and I'm assuming this is intentional. Just making a note here in case it wasn't. > Source/WebKit2/ChangeLog:12 > + > + Double newline yo. Created attachment 103350 [details]
Patch for landing
Comment on attachment 103350 [details] Patch for landing Clearing flags on attachment: 103350 Committed r92680: <http://trac.webkit.org/changeset/92680> All reviewed patches have been landed. Closing bug. |