Bug 65907

Summary: [Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit QtAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: gmak, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review+, kling: commit-queue-
Patch for landing none

Kenneth Rohde Christiansen
Reported 2011-08-09 04:02:49 PDT
SSIA
Attachments
Patch (9.83 KB, patch)
2011-08-09 04:04 PDT, Kenneth Rohde Christiansen 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (9.83 KB, patch)
2011-08-09 06:09 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2011-08-09 04:04:25 PDT
Created attachment 103344 [details] Patch
Andreas Kling
Comment 2 2011-08-09 05:58:52 PDT
Comment on attachment 103344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103344&action=review r=me Two comments though. First, I think if we keep this as public API, we should rework it to have proper request/response mapping (though the point/rect mapping that this patch introduces is certainly better than what we had before.) I don't believe this mechanism should be public though, as it could be completely handled by the respective views. Second, after this patch, a FindZoomableAreaForPoint request can now yield no response whatsoever. Given how the "end-user signal" is used, I don't see a problem with it, and I'm assuming this is intentional. Just making a note here in case it wasn't. > Source/WebKit2/ChangeLog:12 > + > + Double newline yo.
Kenneth Rohde Christiansen
Comment 3 2011-08-09 06:09:51 PDT
Created attachment 103350 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-08-09 07:11:13 PDT
Comment on attachment 103350 [details] Patch for landing Clearing flags on attachment: 103350 Committed r92680: <http://trac.webkit.org/changeset/92680>
WebKit Review Bot
Comment 5 2011-08-09 07:11:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.