| Summary: | Remove deduplicate-tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, evan, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-08-08 15:58:20 PDT
Created attachment 103307 [details]
Patch
BTW, does webkit-patch bulk-optimize-baselines know how to find duplicate png files? It would need to read the checksum out of the png rather than just diffing png files to catch all cases. > BTW, does webkit-patch bulk-optimize-baselines know how to find duplicate png files? It would need to read the checksum out of the png rather than just diffing png files to catch all cases.
The tool is dumb and just taks the sha1 hash of the whole file. If there are two PNGs that are bit-by-bit different yet semantically the same, then bulk-optimize-baselines treats them as different.
We can do something smarter here if that's important. So far, I haven't seen any examples, but I haven't been looking either.
Comment on attachment 103307 [details] Patch Clearing flags on attachment: 103307 Committed r92656: <http://trac.webkit.org/changeset/92656> All reviewed patches have been landed. Closing bug. |