Bug 65886 - Remove deduplicate-tests
Summary: Remove deduplicate-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-08 15:58 PDT by Adam Barth
Modified: 2011-08-08 17:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (25.92 KB, patch)
2011-08-08 15:59 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-08 15:58:20 PDT
Remove deduplicate-tests
Comment 1 Adam Barth 2011-08-08 15:59:51 PDT
Created attachment 103307 [details]
Patch
Comment 2 Tony Chang 2011-08-08 16:00:58 PDT
BTW, does webkit-patch bulk-optimize-baselines know how to find duplicate png files?  It would need to read the checksum out of the png rather than just diffing png files to catch all cases.
Comment 3 Adam Barth 2011-08-08 16:03:34 PDT
> BTW, does webkit-patch bulk-optimize-baselines know how to find duplicate png files?  It would need to read the checksum out of the png rather than just diffing png files to catch all cases.

The tool is dumb and just taks the sha1 hash of the whole file.  If there are two PNGs that are bit-by-bit different yet semantically the same, then bulk-optimize-baselines treats them as different.

We can do something smarter here if that's important.  So far, I haven't seen any examples, but I haven't been looking either.
Comment 4 WebKit Review Bot 2011-08-08 17:19:49 PDT
Comment on attachment 103307 [details]
Patch

Clearing flags on attachment: 103307

Committed r92656: <http://trac.webkit.org/changeset/92656>
Comment 5 WebKit Review Bot 2011-08-08 17:19:54 PDT
All reviewed patches have been landed.  Closing bug.