WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
65886
Remove deduplicate-tests
https://bugs.webkit.org/show_bug.cgi?id=65886
Summary
Remove deduplicate-tests
Adam Barth
Reported
2011-08-08 15:58:20 PDT
Remove deduplicate-tests
Attachments
Patch
(25.92 KB, patch)
2011-08-08 15:59 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-08-08 15:59:51 PDT
Created
attachment 103307
[details]
Patch
Tony Chang
Comment 2
2011-08-08 16:00:58 PDT
BTW, does webkit-patch bulk-optimize-baselines know how to find duplicate png files? It would need to read the checksum out of the png rather than just diffing png files to catch all cases.
Adam Barth
Comment 3
2011-08-08 16:03:34 PDT
> BTW, does webkit-patch bulk-optimize-baselines know how to find duplicate png files? It would need to read the checksum out of the png rather than just diffing png files to catch all cases.
The tool is dumb and just taks the sha1 hash of the whole file. If there are two PNGs that are bit-by-bit different yet semantically the same, then bulk-optimize-baselines treats them as different. We can do something smarter here if that's important. So far, I haven't seen any examples, but I haven't been looking either.
WebKit Review Bot
Comment 4
2011-08-08 17:19:49 PDT
Comment on
attachment 103307
[details]
Patch Clearing flags on attachment: 103307 Committed
r92656
: <
http://trac.webkit.org/changeset/92656
>
WebKit Review Bot
Comment 5
2011-08-08 17:19:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug