scm.delete should delete empty parent directories as well

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

scm.delete should delete empty parent directories as well

[Adam Barth]

Created attachment 103295 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 103295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103295&action=review

LGTM if you fix the self._filesystem issues.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:179
> +        if set(os.listdir(path)) - self._svn_metadata_files:

Seems this should be self._filtesystem.listdir().  Also do we have other ignored files we should exclude?

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:182
> +        dirname = os.path.dirname(path)

self._filesystem.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:188
> +        abs_path = os.path.abspath(path)
> +        parent, base = os.path.split(abs_path)

more self._filesystem.

[Adam Barth]

Comment on attachment 103295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103295&action=review

>> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:182
>> +        dirname = os.path.dirname(path)
> 
> self._filesystem.

Yeah, that's the right thing to do, but I don't see any code in svn.py that uses filesystem.  Maybe you never landed that patch?  These examples are all parallel with _add_parent_directories above.

[Adam Barth]

Committed r92655: <http://trac.webkit.org/changeset/92655>