Bug 65873

Summary: Deprecate rebaseline-chromium-webkit-tests
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-08-08 13:32:50 PDT
Deprecate rebaseline-chromium-webkit-tests
Attachments
Patch (1.82 KB, patch)
2011-08-08 13:35 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-08-08 13:35:17 PDT
Created attachment 103287 [details] Patch
WebKit Review Bot
Comment 2 2011-08-08 14:38:10 PDT
Comment on attachment 103287 [details] Patch Clearing flags on attachment: 103287 Committed r92637: <http://trac.webkit.org/changeset/92637>
WebKit Review Bot
Comment 3 2011-08-08 14:38:14 PDT
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 4 2011-08-10 13:44:22 PDT
This patch adds a deprecation warning, but AFAIK webkit-patch rebaseline-expectations doesn't know about the chromium canaries, so there is a *significant* functionality loss. I don't think that a chromium gardener today can actually use rebaseline-expectations to do their job so this warning is misleading at best.
Adam Barth
Comment 5 2011-08-10 13:52:12 PDT
Have you tried using the script? It does know about the Chromium canaries.
James Robinson
Comment 6 2011-08-10 13:54:38 PDT
Woah, deep magic. Never mind, then :)
Note You need to log in before you can comment on or make changes to this bug.