Summary: | Deprecate rebaseline-chromium-webkit-tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, eric, jamesr, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adam Barth
2011-08-08 13:32:50 PDT
Created attachment 103287 [details]
Patch
Comment on attachment 103287 [details] Patch Clearing flags on attachment: 103287 Committed r92637: <http://trac.webkit.org/changeset/92637> All reviewed patches have been landed. Closing bug. This patch adds a deprecation warning, but AFAIK webkit-patch rebaseline-expectations doesn't know about the chromium canaries, so there is a *significant* functionality loss. I don't think that a chromium gardener today can actually use rebaseline-expectations to do their job so this warning is misleading at best. Have you tried using the script? It does know about the Chromium canaries. Woah, deep magic. Never mind, then :) |