Summary: | Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandru Chiculita <achicu> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexandru Chiculita
2011-08-08 13:20:01 PDT
Created attachment 103284 [details]
Patch
"positionNewFloatOnLine" is moving the object, so it had to remove it from the tree, move it and add it back in the tree. "removePlacedObject" also sets the isPlaced to false, so the call to x() or y() would assert about isPlaced being false. Now I saved the old position on stack before calling removePlacedObject, so that the assert is avoided.
Comment on attachment 103284 [details]
Patch
r=me
Comment on attachment 103284 [details] Patch Rejecting attachment 103284 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: ILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/platform/PODIntervalTree.h patching file Source/WebCore/platform/PODRedBlackTree.h patching file Source/WebCore/rendering/RenderBlock.cpp patching file Source/WebCore/rendering/RenderBlock.h patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9211121 Created attachment 103383 [details]
Patch
Rebased the patch
Comment on attachment 103383 [details]
Patch
Removing r? since the patch is already landed.
|