Bug 65826

Summary: [WK2] Export WebCoreSupport::injectInternalsObject.
Product: WebKit Reporter: Holger Freyther <zecke>
Component: New BugsAssignee: Holger Freyther <zecke>
Status: NEW    
Severity: Normal CC: ap, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65470    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Reduce symbols (force enabling of export macros)
none
Use WEBKIT_EXPORTDATA darin: review+

Holger Freyther
Reported 2011-08-07 04:32:45 PDT
Created attachment 103178 [details] Patch Export injectInternalsObject for WebKitTestRunner (inject bundle). This is required when using -fvisibility=hidden for WebCore symbols. The export macros come from bug #27551, the re-introduction of -fvisibility=hidden is tracked in bug #65470.
Attachments
Patch (1.96 KB, patch)
2011-08-07 04:32 PDT, Holger Freyther 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Reduce symbols (force enabling of export macros) (2.39 KB, patch)
2011-08-07 04:40 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Use WEBKIT_EXPORTDATA (4.22 KB, patch)
2011-08-08 05:03 PDT, Holger Freyther 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-08-07 04:35:00 PDT
Attachment 103178 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Holger Freyther
Comment 2 2011-08-07 04:40:23 PDT
Created attachment 103179 [details] Reduce symbols (force enabling of export macros) This maybe should wait for bug #27551 to be resolved first. The stripped library I get on x86 is: 29616930 2011-08-07 07:48 lib/libQtWebKit.so.4.10.0
WebKit Review Bot
Comment 3 2011-08-07 04:46:06 PDT
Comment on attachment 103178 [details] Patch Attachment 103178 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9329452
WebKit Review Bot
Comment 4 2011-08-07 04:48:42 PDT
Comment on attachment 103178 [details] Patch Attachment 103178 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9324568
Holger Freyther
Comment 5 2011-08-08 05:03:30 PDT
Created attachment 103230 [details] Use WEBKIT_EXPORTDATA build tested on chromium
Darin Adler
Comment 6 2011-10-17 13:04:52 PDT
Comment on attachment 103230 [details] Use WEBKIT_EXPORTDATA Looks like this breaks the Windows build. Please fix that before landing.
Alexey Proskuryakov
Comment 7 2012-05-31 11:21:22 PDT
Is this still needed?
Note You need to log in before you can comment on or make changes to this bug.