Bug 65821

Summary: Don't form identifiers the first time a string is used as a property name.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2011-08-06 15:24:44 PDT
This is a 1% win on SunSpider.
Attachments
The patch (9.55 KB, patch)
2011-08-06 15:31 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-08-06 15:31:22 PDT
Created attachment 103167 [details] The patch
WebKit Review Bot
Comment 2 2011-08-06 15:33:59 PDT
Attachment 103167 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/PropertyMapHashTable.h:158: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2011-08-06 15:53:47 PDT
Comment on attachment 103167 [details] The patch r=me, but fix the style problem
Gavin Barraclough
Comment 4 2011-08-06 20:45:04 PDT
Fixed in r92569
Note You need to log in before you can comment on or make changes to this bug.