Bug 65821 - Don't form identifiers the first time a string is used as a property name.
Summary: Don't form identifiers the first time a string is used as a property name.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2011-08-06 15:24 PDT by Gavin Barraclough
Modified: 2011-08-06 20:45 PDT (History)
1 user (show)

See Also:

The patch (9.55 KB, patch)
2011-08-06 15:31 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-08-06 15:24:44 PDT
This is a 1% win on SunSpider.
Comment 1 Gavin Barraclough 2011-08-06 15:31:22 PDT
Created attachment 103167 [details]
The patch
Comment 2 WebKit Review Bot 2011-08-06 15:33:59 PDT
Attachment 103167 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/PropertyMapHashTable.h:158:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2011-08-06 15:53:47 PDT
Comment on attachment 103167 [details]
The patch

r=me, but fix the style problem
Comment 4 Gavin Barraclough 2011-08-06 20:45:04 PDT
Fixed in r92569