Bug 65816

Summary: Test how AudioBufferSourceNode reacts when given too few arguments
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65787    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-08-06 12:52:49 PDT
Test how AudioBufferSourceNode reacts when given too few arguments
Attachments
Patch (2.23 KB, patch)
2011-08-06 12:55 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2011-08-08 13:19 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-08-06 12:55:28 PDT
Created attachment 103158 [details] Patch
WebKit Review Bot
Comment 2 2011-08-08 11:50:11 PDT
Comment on attachment 103158 [details] Patch Attachment 103158 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9329944 New failing tests: webaudio/audionode.html
Adam Barth
Comment 3 2011-08-08 13:19:02 PDT
Created attachment 103282 [details] Patch
Chris Rogers
Comment 4 2011-08-10 11:58:13 PDT
Hi Adam, thanks for the patch. This seems fine to me. I few of my demos were passing in no argument to noteOn(), which I was intending to support (meaning "play now"). But, thinking about this a bit more, I think it's a good idea for people to think about these APIs (especially noteOn()) as they relate to time. So, the time value should always be explicit (even if 0 is passed in which means "play now").
Adam Barth
Comment 5 2011-08-10 13:12:12 PDT
Chris, it's entirely up to you. I'm happy to mark the arguments as optional if that's what you'd prefer.
Chris Rogers
Comment 6 2011-08-10 13:33:01 PDT
Hi Adam, I think the requirement for the argument is fine. I've already updated my two samples with the change. The specification doesn't mark the argument as optional, and I don't think there are any significant demos other people have done which this will break. In general, though, I'd always appreciate a "heads-up" for any (potentially breaking) API change.
Adam Barth
Comment 7 2011-08-10 14:12:02 PDT
> In general, though, I'd always appreciate a "heads-up" for any (potentially breaking) API change. Definitely. There was some miscommunication. I thought you had already signed off.
WebKit Review Bot
Comment 8 2011-08-10 21:01:03 PDT
Comment on attachment 103282 [details] Patch Clearing flags on attachment: 103282 Committed r92817: <http://trac.webkit.org/changeset/92817>
WebKit Review Bot
Comment 9 2011-08-10 21:01:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.