Summary: | Potential Leaks - RetainPtr<> over retaining Create'd objects | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, joepeck, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2011-08-05 19:35:19 PDT
Created attachment 103141 [details]
[PATCH] Potential Fix (Untested, just code inspection and change)
Each of these looks like they should be an Adopt after reading
the immediately surrounding code.
Did you do the same grep for Copy? Comment on attachment 103141 [details] [PATCH] Potential Fix (Untested, just code inspection and change) Clearing flags on attachment: 103141 Committed r92552: <http://trac.webkit.org/changeset/92552> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > Did you do the same grep for Copy? Yep that turned up both of these: <http://webkit.org/b/65789> Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation <http://webkit.org/b/65790> [QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy Thanks! |