Bug 65802
| Summary: | Add tests for whether arguments are optional for addEventListener and removeEventListener | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 65787 | ||
Adam Barth
As described in https://bugs.webkit.org/show_bug.cgi?id=65771, the patch in bug https://bugs.webkit.org/show_bug.cgi?id=63417 combined with the legacy default argument removal seemed to affect the behavior of addEventListener/removeEventListener. I need to look in the code generator and understand why / we need to determine which behavior we want.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
Although these are special-cased in the code generator, it appears that the argument handling uses some of normal argument handling code path, so we did change behavior here.
Our new behavior is more aligned with Firefox, so I'm inclined to wait and see if we receive any compatibility complaints. This has been in the tree for a bit and I'm not aware of any compat issues. If you know of any, please let me know.
Adam Barth
I think the best resolution here is to add tests and to be on the lookout for compatibility problems.