Summary: | Add testing for --force-compositing-mode to windows.internal | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||||||||
Component: | WebCore Misc. | Assignee: | Adrienne Walker <enne> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, enne, gustavo, haraken, jamesr, morrita, simon.fraser, tonikitoo, vangelis, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 55257 | ||||||||||||
Attachments: |
|
Description
Adrienne Walker
2011-08-05 10:42:38 PDT
Created attachment 103130 [details]
Patch
Comment on attachment 103130 [details] Patch Attachment 103130 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9317519 I believe when touching window.internals you have to muck about with a whole bunch of export files. Is that right, Dimitri? (In reply to comment #3) > I believe when touching window.internals you have to muck about with a whole bunch of export files. Is that right, Dimitri? Yes indeedy. That's what those busted EWS bubbles say. Comment on attachment 103130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103130&action=review > Source/WebCore/testing/Internals.cpp:195 > +void Internals::setForceCompositingMode(Document* document, bool enabled, ExceptionCode& ec) > +{ > + if (!document) { > + ec = INVALID_ACCESS_ERR; > + return; > + } > + > + Settings* settings = document->settings(); > + if (!settings) { > + ec = INVALID_ACCESS_ERR; > + return; > + } > + settings->setForceCompositingMode(enabled); > +} This looks like a bunch of boilerplate. Should we make a macro so do this work? I guess it's the first one, so maybe we should wait until we have more than one. :) Comment on attachment 103130 [details] Patch Attachment 103130 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9317537 (In reply to comment #5) > (From update of attachment 103130 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103130&action=review > > > Source/WebCore/testing/Internals.cpp:195 > > +void Internals::setForceCompositingMode(Document* document, bool enabled, ExceptionCode& ec) > > +{ > > + if (!document) { > > + ec = INVALID_ACCESS_ERR; > > + return; > > + } > > + > > + Settings* settings = document->settings(); > > + if (!settings) { > > + ec = INVALID_ACCESS_ERR; > > + return; > > + } > > + settings->setForceCompositingMode(enabled); > > +} > > This looks like a bunch of boilerplate. Should we make a macro so do this work? I guess it's the first one, so maybe we should wait until we have more than one. :) It would be cool if WebKitIDL supported [ConvertNullToException=INVALID_ACCESS_ERR]. Created attachment 103278 [details]
Patch
Comment on attachment 103278 [details] Patch Attachment 103278 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9336002 Created attachment 103286 [details]
Patch
Created attachment 103305 [details]
Patch
(In reply to comment #11) > Created an attachment (id=103305) [details] > Patch Finally. All green. :) Does anybody have any feedback other than reducing boilerplate? Committed r92697: <http://trac.webkit.org/changeset/92697> |