Bug 65771

Summary: REGRESSION(r92433): media/video-src-change.html fails
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, koivisto, pilgrim, sam, simon.fraser
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fixes the test none

Ryosuke Niwa
Reported 2011-08-05 09:07:00 PDT
media/video-src-change.html started to fail after http://trac.webkit.org/changeset/92433 because the test assumes the second argument for removeEventListener to be optional.
Attachments
fixes the test (1.21 KB, patch)
2011-08-05 09:46 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-08-05 09:10:45 PDT
All regressions are P1.
Ryosuke Niwa
Comment 2 2011-08-05 09:15:06 PDT
Looking at EventTarget code: http://trac.webkit.org/browser/trunk/Source/WebCore/dom/EventTarget.cpp#L246 It seems like the test code is wrong. We should be giving the listener as the second argument: 31 if (++loadedCount >= 2) { 32 mediaElement.removeEventListener('loadedmetadata'); 33 endTest(); 34 return; 35 }
Ryosuke Niwa
Comment 3 2011-08-05 09:46:58 PDT
Created attachment 103079 [details] fixes the test
Ryosuke Niwa
Comment 4 2011-08-05 10:13:04 PDT
Comment on attachment 103079 [details] fixes the test Clearing flags on attachment: 103079 Committed r92484: <http://trac.webkit.org/changeset/92484>
Ryosuke Niwa
Comment 5 2011-08-05 10:13:07 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 6 2011-08-05 12:49:56 PDT
This bug is blowing my mind. I thought removeEventListener was special-cased by the code generator. The IDL files shouldn't affect the generated code.
Note You need to log in before you can comment on or make changes to this bug.