Bug 65771

Summary:

REGRESSION(r92433): media/video-src-change.html fails

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

UI Events

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric.carlson, koivisto, pilgrim, sam, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
fixes the test	none

Description Ryosuke Niwa 2011-08-05 09:07:00 PDT

media/video-src-change.html started to fail after http://trac.webkit.org/changeset/92433 because the test assumes the second argument for removeEventListener to be optional.

Comment 1 Ryosuke Niwa 2011-08-05 09:10:45 PDT

All regressions are P1.

Comment 2 Ryosuke Niwa 2011-08-05 09:15:06 PDT

Looking at EventTarget code:
http://trac.webkit.org/browser/trunk/Source/WebCore/dom/EventTarget.cpp#L246

It seems like the test code is wrong.  We should be giving the listener as the second argument:
31	                if (++loadedCount >= 2) {
32	                    mediaElement.removeEventListener('loadedmetadata');
33	                    endTest();
34	                    return;
35	                }

Comment 3 Ryosuke Niwa 2011-08-05 09:46:58 PDT

Created attachment 103079 [details]
fixes the test

Comment 4 Ryosuke Niwa 2011-08-05 10:13:04 PDT

Comment on attachment 103079 [details]
fixes the test

Clearing flags on attachment: 103079

Committed r92484: <http://trac.webkit.org/changeset/92484>

Comment 5 Ryosuke Niwa 2011-08-05 10:13:07 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Adam Barth 2011-08-05 12:49:56 PDT

This bug is blowing my mind.  I thought removeEventListener was special-cased by the code generator.  The IDL files shouldn't affect the generated code.