Bug 65762

Summary: Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, jamesr, mikelawther, simon.fraser, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ben Wells 2011-08-05 03:24:49 PDT
Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
Comment 1 Ben Wells 2011-08-05 03:31:32 PDT
In a development version of gmail we have noticed some performance problems with table cells with rgba borders on one side only.

The performance degradation appeared with the change for 63174, which fixed a bug with alpha borders where they are not all visible by taking this drawing off the optimized path. This change introduces a new optimized path for this case.
Comment 2 Ben Wells 2011-08-05 03:32:40 PDT
Created attachment 103056 [details]
Patch
Comment 3 Ben Wells 2011-08-05 03:36:00 PDT
Comment on attachment 103056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103056&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:-1491
> -            paintBorderSides(graphicsContext, style, outerBorder, innerBorder, edges, AllBorderEdges, bleedAvoidance, includeLogicalLeftEdge, includeLogicalRightEdge, antialias);

Note this function is still called later on, without clipping, in the cases where it was used to be called here (!outerBorder.isRounded and !haveAlphaColor)
Comment 4 WebKit Review Bot 2011-08-05 17:16:06 PDT
Comment on attachment 103056 [details]
Patch

Clearing flags on attachment: 103056

Committed r92529: <http://trac.webkit.org/changeset/92529>
Comment 5 WebKit Review Bot 2011-08-05 17:16:10 PDT
All reviewed patches have been landed.  Closing bug.