Bug 65759 – Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure

[Adam Barth]

Created attachment 103052 [details]
Patch

[Adam Barth]

Comment on attachment 103052 [details]
Patch

Clearing flags on attachment: 103052

Committed r92493: <http://trac.webkit.org/changeset/92493>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[Balazs Kelemen]

It broke the main Qt Release bot:
ERROR: test_rebaseline_test (webkitpy.tool.commands.rebaseline_unittest.TestRebaseline)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 48, in test_rebaseline_test
    OutputCapture().assert_outputs(self, command._rebaseline_test, ["Webkit Linux", "userscripts/another-test.html", "txt"], expected_stdout=expected_stdout)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 63, in assert_outputs
    return_value = function(*args, **kwargs)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 109, in _rebaseline_test
    self._save_baseline(self._tool.web.get_binary(source_baseline, convert_404_to_None=True), target_baseline)
TypeError: get_binary() got an unexpected keyword argument 'convert_404_to_None'

Have you got an idea about what's going on here?

[Dimitri Glazkov (Google)]

(In reply to comment #4)
> It broke the main Qt Release bot:
> ERROR: test_rebaseline_test (webkitpy.tool.commands.rebaseline_unittest.TestRebaseline)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 48, in test_rebaseline_test
>     OutputCapture().assert_outputs(self, command._rebaseline_test, ["Webkit Linux", "userscripts/another-test.html", "txt"], expected_stdout=expected_stdout)
>   File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 63, in assert_outputs
>     return_value = function(*args, **kwargs)
>   File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 109, in _rebaseline_test
>     self._save_baseline(self._tool.web.get_binary(source_baseline, convert_404_to_None=True), target_baseline)
> TypeError: get_binary() got an unexpected keyword argument 'convert_404_to_None'
> 
> Have you got an idea about what's going on here?

Breakage fixed in http://trac.webkit.org/changeset/92515.

[James Robinson]

This patch commented out the chromium gpu linux bot without any obvious explanation.  webkit-patch rebaseline-expectations does not seem to work at all for linux gpu tests now.

[Adam Barth]

> This patch commented out the chromium gpu linux bot without any obvious explanation.  webkit-patch rebaseline-expectations does not seem to work at all for linux gpu tests now.

Yeah, I'm not entirely sure what's going on here.  dglazkov said something about those bots being virtual or something.  I've filed Bug 66694.  I'll take a look once I've made some progress on the stability Code Yellow.