Bug 65733

Summary: [skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: benwells, jamesr, mikelawther, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ben Wells
Reported 2011-08-04 16:23:46 PDT
[skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers
Attachments
Patch (2.85 KB, patch)
2011-08-04 16:28 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Patch (2.80 KB, patch)
2011-08-04 17:07 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben Wells
Comment 1 2011-08-04 16:28:41 PDT
Created attachment 103002 [details] Patch
Ben Wells
Comment 2 2011-08-04 16:31:04 PDT
Comment on attachment 103002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103002&action=review > Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:286 > + makeGrContextCurrent(); Is this the correct place to put this?
James Robinson
Comment 3 2011-08-04 16:33:40 PDT
Comment on attachment 103002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103002&action=review >> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:286 >> + makeGrContextCurrent(); > > Is this the correct place to put this? I think you missed the SkDevice::kVector_Capability branch of this function. I'm also pretty sure that devices with vector capabilities don't have GrContexts, but that does seem a little dodgy to rely on.
Ben Wells
Comment 4 2011-08-04 17:07:35 PDT
Created attachment 103006 [details] Patch
James Robinson
Comment 5 2011-08-10 11:57:56 PDT
Comment on attachment 103006 [details] Patch OK
WebKit Review Bot
Comment 6 2011-08-10 12:47:57 PDT
Comment on attachment 103006 [details] Patch Clearing flags on attachment: 103006 Committed r92787: <http://trac.webkit.org/changeset/92787>
WebKit Review Bot
Comment 7 2011-08-10 12:48:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.