Bug 65733 - [skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers
Summary: [skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Wells
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-04 16:23 PDT by Ben Wells
Modified: 2011-08-10 12:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.85 KB, patch)
2011-08-04 16:28 PDT, Ben Wells 		no flags Details | Formatted Diff | Diff
Patch (2.80 KB, patch)
2011-08-04 17:07 PDT, Ben Wells 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Wells 2011-08-04 16:23:46 PDT 
[skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers
Comment 1 Ben Wells 2011-08-04 16:28:41 PDT 
Created attachment 103002 [details]
Patch
Comment 2 Ben Wells 2011-08-04 16:31:04 PDT 
Comment on attachment 103002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103002&action=review

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:286
> +        makeGrContextCurrent();

Is this the correct place to put this?
Comment 3 James Robinson 2011-08-04 16:33:40 PDT 
Comment on attachment 103002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103002&action=review

>> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:286
>> +        makeGrContextCurrent();
> 
> Is this the correct place to put this?

I think you missed the SkDevice::kVector_Capability branch of this function.  I'm also pretty sure that devices with vector capabilities don't have GrContexts, but that does seem a little dodgy to rely on.
Comment 4 Ben Wells 2011-08-04 17:07:35 PDT 
Created attachment 103006 [details]
Patch
Comment 5 James Robinson 2011-08-10 11:57:56 PDT 
Comment on attachment 103006 [details]
Patch

OK
Comment 6 WebKit Review Bot 2011-08-10 12:47:57 PDT 
Comment on attachment 103006 [details]
Patch

Clearing flags on attachment: 103006

Committed r92787: <http://trac.webkit.org/changeset/92787>
Comment 7 WebKit Review Bot 2011-08-10 12:48:02 PDT 
All reviewed patches have been landed.  Closing bug.