Bug 65698

Summary: REGRESSION: webkitRequestAnimationFrame's element argument needs to be marked optional
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: DOMAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, jamesr, pilgrim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
webkit.review.bot: commit-queue-
v2 patch none

Darin Fisher (:fishd, Google)
Reported 2011-08-04 09:51:28 PDT
REGRESSION: webkitRequestAnimationFrame's element argument needs to be marked optional regressed from http://trac.webkit.org/changeset/92313
Attachments
v1 patch (1.24 KB, patch)
2011-08-04 10:28 PDT, Darin Fisher (:fishd, Google) 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
v2 patch (1.26 KB, patch)
2011-08-04 10:51 PDT, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2011-08-04 10:28:56 PDT
Created attachment 102942 [details] v1 patch
WebKit Review Bot
Comment 2 2011-08-04 10:38:09 PDT
Comment on attachment 102942 [details] v1 patch Attachment 102942 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9300730
Darin Fisher (:fishd, Google)
Comment 3 2011-08-04 10:51:11 PDT
Created attachment 102945 [details] v2 patch Whoops, this time with Optional=CallWithDefaultValue!
James Robinson
Comment 4 2011-08-04 11:02:47 PDT
Comment on attachment 102945 [details] v2 patch R=me
WebKit Review Bot
Comment 5 2011-08-04 11:19:57 PDT
Comment on attachment 102945 [details] v2 patch Clearing flags on attachment: 102945 Committed r92392: <http://trac.webkit.org/changeset/92392>
WebKit Review Bot
Comment 6 2011-08-04 11:20:02 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2011-08-04 11:51:20 PDT
Comment on attachment 102945 [details] v2 patch No test? Thanks for fixing this issue. Sorry for the mess.
Darin Fisher (:fishd, Google)
Comment 8 2011-08-04 12:40:02 PDT
See fast/animation/request-animation-frame-*, which are all skipped on non-Chromium ports. It looks like I should indeed have added a test that does not pass the element parameter :( Will do that as a follow-up patch in a separate bug.
Darin Fisher (:fishd, Google)
Comment 9 2011-08-04 12:41:33 PDT
See bug 65710 for adding a test.
Note You need to log in before you can comment on or make changes to this bug.