| Summary: | REGRESSION: webkitRequestAnimationFrame's element argument needs to be marked optional | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||||
| Component: | DOM | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, jamesr, pilgrim, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Fisher (:fishd, Google)
2011-08-04 09:51:28 PDT
Created attachment 102942 [details]
v1 patch
Comment on attachment 102942 [details] v1 patch Attachment 102942 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9300730 Created attachment 102945 [details]
v2 patch
Whoops, this time with Optional=CallWithDefaultValue!
Comment on attachment 102945 [details]
v2 patch
R=me
Comment on attachment 102945 [details] v2 patch Clearing flags on attachment: 102945 Committed r92392: <http://trac.webkit.org/changeset/92392> All reviewed patches have been landed. Closing bug. Comment on attachment 102945 [details]
v2 patch
No test? Thanks for fixing this issue. Sorry for the mess.
See fast/animation/request-animation-frame-*, which are all skipped on non-Chromium ports. It looks like I should indeed have added a test that does not pass the element parameter :( Will do that as a follow-up patch in a separate bug. |