Summary: | IndexedDB: Stop using free-lists for database/object store/index ids. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||
Component: | New Bugs | Assignee: | Hans Wennborg <hans> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dgrogan, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Hans Wennborg
2011-08-04 03:26:50 PDT
Created attachment 102893 [details]
Patch
David, would you like to take a look? Comment on attachment 102893 [details]
Patch
LGTM
Thanks! Tony, would you like to take a look? Comment on attachment 102893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293 > + return -1; Do you mean to return false here? (In reply to comment #5) > (From update of attachment 102893 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review > > > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293 > > + return -1; > > Do you mean to return false here? Yes, of course. Good catch! Thanks for the review! Committed r92468: <http://trac.webkit.org/changeset/92468> |