Bug 65678

Summary: IndexedDB: Stop using free-lists for database/object store/index ids.
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Hans Wennborg
Reported 2011-08-04 03:26:50 PDT
IndexedDB: Stop using free-lists for database/object store/index ids.
Attachments
Patch (9.19 KB, patch)
2011-08-04 03:33 PDT, Hans Wennborg 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2011-08-04 03:33:37 PDT
Created attachment 102893 [details] Patch
Hans Wennborg
Comment 2 2011-08-04 03:34:35 PDT
David, would you like to take a look?
David Grogan
Comment 3 2011-08-04 10:02:11 PDT
Comment on attachment 102893 [details] Patch LGTM
Hans Wennborg
Comment 4 2011-08-04 10:06:43 PDT
Thanks! Tony, would you like to take a look?
Tony Chang
Comment 5 2011-08-04 10:23:00 PDT
Comment on attachment 102893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293 > + return -1; Do you mean to return false here?
Hans Wennborg
Comment 6 2011-08-05 01:16:05 PDT
(In reply to comment #5) > (From update of attachment 102893 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review > > > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293 > > + return -1; > > Do you mean to return false here? Yes, of course. Good catch! Thanks for the review!
Hans Wennborg
Comment 7 2011-08-05 01:43:14 PDT
Committed r92468: <http://trac.webkit.org/changeset/92468>
Note You need to log in before you can comment on or make changes to this bug.