Bug 65659

Summary: Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
Product: WebKit Reporter: Sailesh Agrawal <sail>
Component: New BugsAssignee: Sailesh Agrawal <sail>
Status: RESOLVED FIXED    
Severity: Normal CC: jam, jamesr, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sailesh Agrawal
Reported 2011-08-03 18:24:39 PDT
Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
Attachments
Patch (3.96 KB, patch)
2011-08-03 18:27 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sailesh Agrawal
Comment 1 2011-08-03 18:27:09 PDT
Created attachment 102867 [details] Patch
James Robinson
Comment 2 2011-08-03 18:32:18 PDT
Comment on attachment 102867 [details] Patch OK
Nico Weber
Comment 3 2011-08-03 18:36:53 PDT
Comment on attachment 102867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40 > typedef NSInteger NSScrollerStyle; is this used anywhere? > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44 > +typedef uint32 wkScrollerStyle; this is now different from before on 64bit builds. is that significant?
James Robinson
Comment 4 2011-08-03 18:39:36 PDT
Comment on attachment 102867 [details] Patch clearing cq, thakis' question seems relevant. he can flip cq+ when he's satisfied
Sailesh Agrawal
Comment 5 2011-08-03 18:50:19 PDT
Comment on attachment 102867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40 >> typedef NSInteger NSScrollerStyle; > > is this used anywhere? This is used inside ScrollAnimatorChromiumMac.mm and ScrollbarOverlayUtilitiesChromiumMac.mm. Having it here seemed better than having to duplicate it in both .mm files. >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44 >> +typedef uint32 wkScrollerStyle; > > this is now different from before on 64bit builds. is that significant? It's not because I'm only using it for the wk* function. All delegate callback functions and private cocoa classes still use NSScrollerStyle.
WebKit Review Bot
Comment 6 2011-08-03 19:35:54 PDT
Comment on attachment 102867 [details] Patch Clearing flags on attachment: 102867 Committed r92343: <http://trac.webkit.org/changeset/92343>
WebKit Review Bot
Comment 7 2011-08-03 19:35:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.