Bug 65624

Summary: [Qt] Make navigation actions properly usable in QML.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: New BugsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Major CC: benjamin, kling, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexis Menard (darktears)
Reported 2011-08-03 09:36:28 PDT
[Qt] Make navigation actions properly usable in QML.
Attachments
Patch (22.95 KB, patch)
2011-08-03 09:44 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (23.00 KB, patch)
2011-08-04 06:54 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-08-03 09:44:23 PDT
Created attachment 102791 [details] Patch
Benjamin Poulain
Comment 2 2011-08-04 06:27:55 PDT
Comment on attachment 102791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102791&action=review > Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h:46 > + QWebNavigationController* navigationController; Look like this is leaked (in both views). OwnPtr to the rescue? Or add QObject* parent to the constructor of QWebNavigationController. > Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.cpp:33 > + ASSERT(pageProxy) maybe so it fails early in case of mistake?
Alexis Menard (darktears)
Comment 3 2011-08-04 06:54:50 PDT
Created attachment 102906 [details] Patch
Benjamin Poulain
Comment 4 2011-08-04 06:56:46 PDT
Comment on attachment 102906 [details] Patch Looks good
WebKit Review Bot
Comment 5 2011-08-04 07:57:19 PDT
Comment on attachment 102906 [details] Patch Clearing flags on attachment: 102906 Committed r92373: <http://trac.webkit.org/changeset/92373>
WebKit Review Bot
Comment 6 2011-08-04 07:57:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.