Bug 65607

Summary: Web Inspector: Console scroll position should be saved when switching panels.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Description Vsevolod Vlasov 2011-08-03 04:23:23 PDT
Console scroll position should be saved when switching panels.
Comment 1 Vsevolod Vlasov 2011-08-03 04:27:05 PDT
Created attachment 102766 [details]
Patch
Comment 2 Pavel Feldman 2011-08-03 04:44:58 PDT
Comment on attachment 102766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102766&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:746
> +        return this.messagesElement ? this.messagesElement.scrollLeft : 0;

no need to check

> Source/WebCore/inspector/front-end/ConsoleView.js:751
> +        if (this.messagesElement)

no need to check.

> Source/WebCore/inspector/front-end/ConsoleView.js:757
> +        return this.messagesElement ? this.messagesElement.scrollTop : 0;

ditto

> Source/WebCore/inspector/front-end/ConsoleView.js:762
> +        if (this.messagesElement)

ditto
Comment 3 Vsevolod Vlasov 2011-08-03 07:33:47 PDT
Committed r92278: <http://trac.webkit.org/changeset/92278>