Bug 65586

Summary: Chromium Mac: Make sure scrollbars flash when web page loads
Product: WebKit Reporter: Sailesh Agrawal <sail>
Component: New BugsAssignee: Sailesh Agrawal <sail>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sailesh Agrawal
Reported 2011-08-02 18:11:16 PDT
Chromium Mac: Make sure scrollbars flash when web page loads
Attachments
Patch (1.88 KB, patch)
2011-08-02 18:14 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2011-08-03 14:36 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sailesh Agrawal
Comment 1 2011-08-02 18:14:27 PDT
Created attachment 102726 [details] Patch
Sailesh Agrawal
Comment 2 2011-08-02 18:15:16 PDT
This patch fixes the following Chromium bug: http://code.google.com/p/chromium/issues/detail?id=90522
James Robinson
Comment 3 2011-08-03 14:27:33 PDT
Comment on attachment 102726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102726&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=65586 > + > + On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars. You need a 'Reviewed by' line here or the commit bot will reject you.
Sailesh Agrawal
Comment 4 2011-08-03 14:36:39 PDT
Created attachment 102828 [details] Patch
Sailesh Agrawal
Comment 5 2011-08-03 14:37:10 PDT
> You need a 'Reviewed by' line here or the commit bot will reject you. Fixed.
WebKit Review Bot
Comment 6 2011-08-03 15:24:26 PDT
Comment on attachment 102828 [details] Patch Clearing flags on attachment: 102828 Committed r92316: <http://trac.webkit.org/changeset/92316>
WebKit Review Bot
Comment 7 2011-08-03 15:24:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.