| Summary: | Crash in ResourceResponse::platformCompare() with USE(CFNETWORK) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||||
| Component: | Platform | Assignee: | Pratik Solanki <psolanki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ddkilzer, jberlin, psolanki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 102718 [details]
Patch
Comment on attachment 102718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102718&action=review > Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:144 > +#if PLATFORM(MAC) > + // CFEqual crashes if you pass it 0 and on Mac we can end up with cfURLResponse() being 0. > + if (!a.cfURLResponse() || !b.cfURLResponse()) > + return a.cfURLResponse() == b.cfURLResponse(); > +#endif This should be unconditional, not inside #if PLATFORM(MAC) Created attachment 102724 [details]
Patch
Updated patch to make it unconditional. Comment on attachment 102724 [details]
Patch
r=me
Committed r92261: <http://trac.webkit.org/changeset/92261> |
Code does return CFEqual(a.cfURLResponse(), b.cfURLResponse()); And it crashes the cfURLResponses are 0 and CFEqual doesn't like that. This is fine on the Foundation side since we do return a.nsURLResponse() == b.nsURLResponse();